Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install test #3509

Closed
wants to merge 1 commit into from
Closed

Fix install test #3509

wants to merge 1 commit into from

Conversation

MDrakos
Copy link
Member

@MDrakos MDrakos commented Sep 24, 2024

BugDX-3074 Nightly failure: TestInstallIntegrationTestSuite/TestInstall_NoMatches_Alternatives

The underlying issue is that when we don't find an ingredient for the requested requirement we don't have a namespace. In this example when we call the search endpoint with database and no namespace we first get a bunch of results for Perl.

I've updated the getSuggestions function to compose namespaces for each language and call the search endpoint for each one.

@github-actions github-actions bot changed the base branch from master to version/0-47-0-RC1 September 24, 2024 21:55
@MDrakos MDrakos requested a review from Naatan September 24, 2024 22:42
Copy link
Member

@Naatan Naatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a viable solution as it would scale up our search calls for each namespace being targeted in our project. The search endpoint is known to be slow. Even the newly optimized one. Already with just the one lookup it's kinda awkward when having to wait for the error to appear.

Perhaps the new search endpoint will allow us to search across multiple namespaces. Suggest marking this issue blocked by DX-2994.

@MDrakos MDrakos closed this Sep 24, 2024
@MDrakos MDrakos deleted the DX-3074 branch September 24, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants