Map to ingredient when its source can be identified as a single straight path #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by wheels won't have an ingredient
github-actions
bot
changed the base branch from
master
to
version/0-46-0-RC1
Naatan
changed the title
MDrakos
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem I found was that some artifacts (in this case urllib3) seem to be generated from python wheels, which means that in the buildplan you have a state tool artifact that has a python wheel artifact as its source, which then in turn has the actual ingredient as its source.
I've addressed this by still associating artifacts to ingredients so long as each step it iterates over to get to the source only has a single input node.