Sort artifact changesets by name. #3485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it's not as simple as sorting buildplan artifacts once and you're done. For example, the
DiffArtifacts()
function creates a map of artifacts, which is inherently unsorted, so we have to sort it after the fact. (It doesn't matter whether or not the incoming artifacts are sorted.) Other functions throughout the codebase have the capability to do something similar (if they do not already). We could either:This PR chooses option 2, which sorts the
DiffArtifacts()
output. This results in CVE lists, change summary lists, andstate upgrade
lists outputting sorted lists of artifacts.