Fixed disabling of security prompts in e2e tests. #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Aug 20, 2024
•
mitchell-as
commented
 DX-3018 Nightly failures: non-checkout tests that checkout projects with lots of CVEs
|
mitchell-as
commented
Aug 20, 2024
| @@ -182,7 +182,7 @@ func new(t *testing.T, retainDirs, updatePath bool, extraEnv ...string) *Session | |||
| err = fileutils.Touch(filepath.Join(dirs.Base, installation.InstallDirMarker)) | |||
| require.NoError(session.T, err) | |||
|
|
|||
| cfg, err := config.New() | |||
| cfg, err := config.NewCustom(dirs.Config, singlethread.New(), true) | |||
There was a problem hiding this comment.
This is the fix.
mitchell-as
force-pushed
the
mitchell/dx-3018
branch
from
c73768e to
9aba7d0
Compare
|
Test failures are known or the usual timeouts. |
MDrakos
approved these changes
Aug 20, 2024
| @@ -182,7 +182,7 @@ func new(t *testing.T, retainDirs, updatePath bool, extraEnv ...string) *Session | |||
| err = fileutils.Touch(filepath.Join(dirs.Base, installation.InstallDirMarker)) | |||
| require.NoError(session.T, err) | |||
|
|
|||
| cfg, err := config.New() | |||
| cfg, err := config.NewCustom(dirs.Config, singlethread.New(), true) | |||
mitchell-as
removed
Test: package
Test: push
Test: import
Test: init
Test: manifest
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.