Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test accidentally restored during a merge. #2861

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Remove test accidentally restored during a merge. #2861

merged 1 commit into from
Nov 1, 2023

Conversation

mitchell-as
Copy link
Contributor

@mitchell-as mitchell-as commented Nov 1, 2023 •
edited by github-actions bot
Loading

BugDX-2310 Nightly failure: TestPackageIntegrationTestSuite/TestPackage_import/valid_requirements.txt

This test was moved to import_int_test.go in a previous commit.

@mitchell-as mitchell-as requested a review from MDrakos November 1, 2023 17:56
@mitchell-as mitchell-as marked this pull request as ready for review November 1, 2023 17:56
MDrakos
MDrakos reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@MDrakos MDrakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is still present in the v42 code... should it also be removed there?

@mitchell-as
Copy link
Contributor Author

No, because that change was targeted at v43: https://github.com/ActiveState/cli/pull/2851/files

@mitchell-as mitchell-as merged commit 80cdf48 into version/0-43-0-RC1 Nov 1, 2023
10 checks passed
@mitchell-as mitchell-as deleted the mitchell/dx-2310 branch November 1, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDrakos MDrakos MDrakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchell-as @MDrakos