Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#387 Links Section is added #388

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

#387 Links Section is added #388

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
999723f
links section is updated
LaxRaj Jan 5, 2024
1935858
formatted with prettier
LaxRaj Jan 7, 2024
9cdd578
requested changes.
LaxRaj Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions components/ContentTemplates/LinksTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,38 @@ other places on the web */`}
</li>
</ul>
</TemplateSection>
{/* For issue #387 */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment is necessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright removed that! and formatted the LinksTemplate.tsx

<TemplateSection sectionName="openInNewPage" title="Open Links in a new page/window.">
<p>
You can use HTML attribute <strong>target</strong> to open the linked documents.
<ul>
<li>
<strong>_blank:</strong> Opens the link in a new tab/window. Great for external links, PDFs, or downloads.
But remember accessibility concerns: screen reader announcements, focus management, user confusion.
</li>
<li>
<strong>_self (default):</strong> Opens the link in the current frame/window.
Classic behavior, but can lose user context for complex interactions.
</li>
<li>
<strong>_parent:</strong> Opens the link in the parent frame/window (if framesets are used).
Not as common nowadays, but can be useful for specific layouts.
</li>
<li>
<strong>_top:</strong> Opens the link in the entire browser window, replacing the current content.
Can be jarring for users, use sparingly.
</li>
<li>
<strong>Named frames:</strong> Opens the link in a pre-defined frame within the current page.
Less common with modern layouts, but still supported.
</li>
</ul>
<CodeBlock
codeSnippet={`<a href="https://accessibleweb.dev" target="_blank">Visit Accessible Web Dev</a>
<!--This Linked page/document would open in a new page/window.-->`}
languageType={"html"}/>
</p>
</TemplateSection>
<TemplateSection sectionName="linkImage" title="Image and Icon Links">
<p>
You can turn an image or icon into a clickable link that takes you to
Expand Down
Loading