New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: selector patch #2

Open

mediaupstream wants to merge 1 commit into master from fix/select-patch

mediaupstream commented Apr 25, 2022

wraps calls to document.querySelectorAll in a try/catch
replaces the custom escapeValue method in favor of CSS.escape from cssesc
incorporates a couple changes from open PRs on the original optimal-select project


          fix: wrap document.querySelectorAll in try/catch. replace escapeValue…

3ea3c69

… with CSS.escape ala cssesc

k2heikkila commented Apr 25, 2022

We're going to leave this on a feature branch to possibly help future merge's with other forks. Audisist points at this branch.

mediaupstream added the don't merge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels