Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support text fields without a value property #274

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Conversation

mwcampbell
Copy link
Contributor

When a provider properly implements text field controls, setting the value property on the outer text field node is redundant, because the text is already provided in the inner inline text boxes. I expect that this would be a performance problem for large amounts of text. So now, accesskit_consumer provides its own value property for single-line text controls, based on the inner text. For multi-line controls without an outer value property, the macOS adapter fires value change events as appropriate, just as the Windows adapter already fires text change events. I've tested these changes on both Windows and macOS using a modified version of egui that doesn't set the value property on the text field.

@mwcampbell mwcampbell merged commit 5ae557b into main Aug 16, 2023
5 checks passed
@mwcampbell mwcampbell deleted the text-value-fixes branch August 16, 2023 18:51
@mwcampbell mwcampbell mentioned this pull request Aug 16, 2023
lunixbochs pushed a commit to talonvoice/accesskit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants