Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.4.4 #1767

Merged
merged 14 commits into from
Oct 3, 2024
Merged

7.4.4 #1767

merged 14 commits into from
Oct 3, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Oct 2, 2024 •
edited
Loading

Release details

Checklist

Before merge

  • Wiki updated with info in ticket listed under Documentation
  • ran npm run prepare-release (which runs npm audit fix, npm run lint-ts, npm run lint:fix, git add, git commit)
  • pushed potential changes made by prepare-release

After merge

  • merged all dependabot PRs that target main branch
  • updated bug template to include the new version
  • updated .mcdevrc for tests to the new version
  • ran npm run version:major/minor/patch
  • pushed version-prep commits
  • merged main branch into develop branch
  • closed GitHub milestone
  • created new GitHub Release

Documentation

... insert updated documentation here ...

Issues

JoernBerkefeld and others added 14 commits September 30, 2024 15:23
@JoernBerkefeld
#1748: resolve sendClassification in transactionalEmail
ffcada5
@JoernBerkefeld
#1748: enhance tests for resolving sendClassificaiton in transactiona…
739c22e 
…lEmail
@JoernBerkefeld
Merge pull request #1755 from Accenture/task/1748-resolve-send-classi…
61a660e 
…fication-in-transactionalemail

Task/1748 resolve send classification in transactionalemail
@JoernBerkefeld
#1749: update journey with data from transactionalEmail
91fdd15
@JoernBerkefeld
Merge pull request #1760 from Accenture/task/1749-update-transactiona…
6698388 
…l-send-journeys-with-newer-data-from-transactionalemail

task/1749 update journey with data from transactionalEmail
@JoernBerkefeld
#1761: fix validation rules for deploy and ensure they work on a clone
233f45f
@JoernBerkefeld
Merge pull request #1762 from Accenture/bug/1761-validation-scripts-n…
7542295 
…ot-executed-correctly-for-deploy

bug/1761 fix validation rules for deploy and ensure they work on a clone
@JoernBerkefeld
#1763: correctly cache transactionalEmail during journey deployment
b636ecd
@JoernBerkefeld
Merge pull request #1764 from Accenture/bug/1763-related-transactiona…
ff68d56 
…lemail-not-found-during-journey-deploy

bug/1763 correctly cache transactionalEmail during journey deployment
@JoernBerkefeld
#1754: add new validation rule noAmpscriptHtmlTag
a650b51
@JoernBerkefeld
#1754: improve look and feel of validation rule warnings (if there is…
519e42f 
… more than one per item)
@JoernBerkefeld
#1754: hide "constructing common object" message from CLI
afeef32
@JoernBerkefeld
#1754: add missing "> to amscript-html check
3f15549
@JoernBerkefeld
Merge pull request #1766 from Accenture/task/1754-add-new-validation-…
847722f 
…rule-to-warn-about-ampscript-getting-wrapped-in-script-tags

Task/1754 add new validation rule to warn about ampscript getting wrapped in script tags
@JoernBerkefeld JoernBerkefeld added this to the 7.4.4 milestone Oct 2, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Oct 2, 2024
@JoernBerkefeld JoernBerkefeld added c/journey COMPONENT c/sendClassification COMPONENT c/transactionalEmail validationRule bug Something isn't working chore Jira issue-type "Task" labels Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Coverage Report

Commit:847722f
Base: main@22b41bb

Type Base This PR
Total Statements Coverage  69.81%  69.76%  (-0.05%)
Total Branches Coverage  68.6%  68.43%  (-0.17%)
Total Functions Coverage  81.68%  81.59%  (-0.09%)
Total Lines Coverage  69.81%  69.76%  (-0.05%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 1d9cff3 into main Oct 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/journey COMPONENT c/sendClassification COMPONENT c/transactionalEmail chore Jira issue-type "Task" validationRule
Projects
None yet
Milestone
7.4.4
1 participant
@JoernBerkefeld