Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.4.3 #1752

Merged
merged 30 commits into from
Sep 30, 2024
Merged

7.4.3 #1752

merged 30 commits into from
Sep 30, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 30, 2024 •
edited
Loading

Release details

Checklist

Before merge

  • Wiki updated with info in ticket listed under Documentation
  • ran npm run prepare-release (which runs npm audit fix, npm run lint-ts, npm run lint:fix, git add, git commit)
  • pushed potential changes made by prepare-release

After merge

  • merged all dependabot PRs that target main branch
  • updated bug template to include the new version
  • updated .mcdevrc for tests to the new version
  • ran npm run version:major/minor/patch
  • pushed version-prep commits
  • merged main branch into develop branch
  • closed GitHub milestone
  • created new GitHub Release

Documentation

... insert updated documentation here ...

Issues

JoernBerkefeld and others added 30 commits September 19, 2024 19:55
@JoernBerkefeld
#1726: improve linting for .mcdev-validations.js
af6b8cd
@JoernBerkefeld
Merge pull request #1727 from Accenture/task/1726-improve-linting-for…
1a2a899 
…-mcdev-validationsjs

task/1726 improve linting for .mcdev-validations.js
@JoernBerkefeld
#1323: add FallbackFromAddress and
defc2cd
@JoernBerkefeld
#1730: resolve deliveryProfileId on triggeredSends in journeys
581e433
@JoernBerkefeld
#1730: fix journey tests
cb3443d
@JoernBerkefeld
#1730: fix general tests
94a8a45
@JoernBerkefeld
#1730: dont resolve senderProfile if sendClassification is only loade…
32722fd 
…d for cache
@JoernBerkefeld
#1730: make deliveryProfile ID update more reliable
4ded753
@JoernBerkefeld
Merge pull request #1731 from Accenture/task/1730-resolve-deliverypro…
ae81246 
…file-in-journeys

Task/1730 resolve deliveryprofile in journeys
@JoernBerkefeld
#1708: resolve user name for modifiedBy and createdBy on event
df50955
@JoernBerkefeld
#1708: resolve user name for modifiedBy and createdBy on dataExtract
2f8805e
@JoernBerkefeld
#1708: resolve user name for modifiedBy and createdBy on senderProfile
d8c035a
@JoernBerkefeld
#1708: clarify that script via rest api does not offer the info on wh…
f602153 
…o created/modified it
@JoernBerkefeld
#1708: resolve user name for modifiedBy and createdBy on verification
c7778f6
@JoernBerkefeld
#1708: fix new createdBy / modifiedBy fields on senderProfile
88b544b
@JoernBerkefeld
#1708: adapt tests for resolving user names on senderProfile, event, …
1915840 
…dataExtract
@JoernBerkefeld
#1708: fix deployment of users after caching improvements prevented B…
fcea359 
…U assignments from always getting loaded
@JoernBerkefeld
#1708: fix user test
e4358f7
@JoernBerkefeld
Merge pull request #1737 from Accenture/task/1708-resolve-createdby-a…
a10addb 
…nd-modifiedby-user-ids-on-other-metadata

Task/1708 resolve createdby and modifiedby user ids on other metadata
@JoernBerkefeld
#1738: skip re-retrieve if all publish actions failed
d3e9479
@JoernBerkefeld
Merge pull request #1739 from Accenture/bug/1738-publish-journey-re-r…
dd5ae93 
…etrieves-journeys-and-transactionalemail-even-if-all-publish-actions-fail

bug/1738 skip re-retrieve if all publish actions failed
@JoernBerkefeld
#1740: add missing preDeployment handling of journey activities
bd57756
@JoernBerkefeld
Merge pull request #1741 from Accenture/bug/1740-javascript-error-on-…
54c274c 
…ccemail-after-deploying-transactional-send-journeys

bug/1740 add missing preDeployment handling of journey activities
@JoernBerkefeld
#1742: correctly retrieve all related transactionalEmails after publi…
d7c410b 
…shing a transactional send journey
@JoernBerkefeld
Merge pull request #1744 from Accenture/bug/1742-publishing-multiple-…
af57ce1 
…transactional-journeys-will-only-retrieve-the-1st-transactionalemail

bug/1742 correctly retrieve all related transactionalEmails after publi…
@JoernBerkefeld
Merge branch 'develop' into bug/1323-senderprofile-not-selectable-in-…
04289d8 
…journey-message-configuration-after-create-via-mcdev

# Conflicts:
#	@types/lib/metadataTypes/SenderProfile.d.ts
#	@types/lib/metadataTypes/SenderProfile.d.ts.map
#	@types/lib/metadataTypes/definitions/SenderProfile.definition.d.ts
#	lib/metadataTypes/SenderProfile.js
#	lib/metadataTypes/definitions/SenderProfile.definition.js
@JoernBerkefeld
#1323: adapt senderProfile tests for added FallbackFromAddress field
145f383
@JoernBerkefeld
Merge pull request #1745 from Accenture/bug/1323-senderprofile-not-se…
6fbdfde 
…lectable-in-journey-message-configuration-after-create-via-mcdev

Bug/1323 senderprofile not selectable in journey message configuration after create via mcdev
@JoernBerkefeld
#1750: improve debug logging for custom validation rules
44be3b9
@JoernBerkefeld
Merge pull request #1751 from Accenture/task/1750-improve-debug-loggi…
31ea3ed 
…ng-for-validation-rule-errors

task/1750 improve debug logging for custom validation rules
@JoernBerkefeld JoernBerkefeld added bug Something isn't working chore Jira issue-type "Task" labels Sep 30, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.3 milestone Sep 30, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

Coverage Report

Commit:31ea3ed
Base: main@01965ee

Type Base This PR
Total Statements Coverage  69.82%  69.81%  (-0.01%)
Total Branches Coverage  68.72%  68.56%  (-0.16%)
Total Functions Coverage  81.57%  81.68%  (+0.11%)
Total Lines Coverage  69.82%  69.81%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 2f8c53e into main Sep 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working chore Jira issue-type "Task"
Projects
None yet
Milestone
7.4.3
1 participant
@JoernBerkefeld