Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/1721 disable auto-opening markdown renderer to enable vscode's git diff viewer #1722

Merged
merged 1 commit into from
Sep 19, 2024
Merged

task/1721 disable auto-opening markdown renderer to enable vscode's git diff viewer #1722

merged 1 commit into from
Sep 19, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 19, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

the diff view only works on text-only views

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld
#1721: disable auto-opening markdown renderer to enable vscode's git …
0da1e24 
…diff viewer

the diff view only works on text-only views
@JoernBerkefeld JoernBerkefeld added this to the 7.4.2 milestone Sep 19, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 19, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Sep 19, 2024 that may be closed by this pull request
[TASK] vscode should open markdown files as text-only to allow using the built-in diff viewer #1721
Closed
@github-actions github-actions bot added the chore Jira issue-type "Task" label Sep 19, 2024
@JoernBerkefeld JoernBerkefeld added the e/IDE EPIC label Sep 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Coverage Report

Commit:0da1e24
Base: develop@0460484

Type Base This PR
Total Statements Coverage  69.82%  69.82%  (+0%)
Total Branches Coverage  68.72%  68.68%  (-0.04%)
Total Functions Coverage  81.57%  81.57%  (+0%)
Total Lines Coverage  69.82%  69.82%  (+0%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit dd001d5 into develop Sep 19, 2024
12 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1721-vscode-should-open-markdown-files-as-text-only-at-first-to-allow-using-the-built-in-diff-viewer branch September 19, 2024 13:26
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/automation COMPONENT c/dataExtension COMPONENT chore Jira issue-type "Task" e/IDE EPIC
Projects
None yet
Milestone
7.4.2
Development

Successfully merging this pull request may close these issues.

[TASK] vscode should open markdown files as text-only to allow using the built-in diff viewer
1 participant
@JoernBerkefeld