Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/126 folders saved to retrieve during deploy even if not listed for retrieval #1720

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 19, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/folder COMPONENT label Sep 19, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.2 milestone Sep 19, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 19, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 19, 2024
Copy link

github-actions bot commented Sep 19, 2024

Coverage Report

Commit:b73213f
Base: develop@79fa77a

Type Base This PR
Total Statements Coverage  69.82%  69.82%  (+0%)
Total Branches Coverage  68.73%  68.72%  (-0.01%)
Total Functions Coverage  81.57%  81.57%  (+0%)
Total Lines Coverage  69.82%  69.82%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/Deployer.js  80.45%  71.95%  100%  80.45%
lib/metadataTypes/Folder.js  71.56%  60.41%  90%  71.56%
lib/metadataTypes/MetadataType.js  82.61%  79.33%  76.54%  82.61%

@JoernBerkefeld JoernBerkefeld merged commit 0460484 into develop Sep 19, 2024
10 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/126-folders-saved-to-retrieve-during-deploy-even-if-not-listed-for-retrieval branch September 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/folder COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] folders saved to retrieve/ during deploy even if not listed for retrieval
1 participant