Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1692 dont flag common vs contact issue on currently running activepublished journeys and events #1698

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Bug/1692 dont flag common vs contact issue on currently running activepublished journeys and events #1698

merged 3 commits into from
Sep 11, 2024

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Sep 11, 2024 •
edited
Loading

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added c/event COMPONENT c/journey COMPONENT labels Sep 11, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.4.1 milestone Sep 11, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Sep 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Sep 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Coverage Report

Commit:e316bc5
Base: develop@64b785f

Type Base This PR
Total Statements Coverage  69.81%  69.79%  (-0.02%)
Total Branches Coverage  68.7%  68.7%  (+0%)
Total Functions Coverage  81.55%  81.55%  (+0%)
Total Lines Coverage  69.81%  69.79%  (-0.02%)
Details (changed files):
File Statements Branches Functions Lines
lib/metadataTypes/Event.js  53.51%  37.31%  70%  53.51%
lib/metadataTypes/Journey.js  58.75%  60.91%  75%  58.75%

@JoernBerkefeld JoernBerkefeld linked an issue Sep 11, 2024 that may be closed by this pull request
[BUG] dont flag common vs contact issue on currently running (active/published) journeys and events #1692
Closed
2 tasks
@JoernBerkefeld JoernBerkefeld merged commit 9cb11a2 into develop Sep 11, 2024
8 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1692-dont-flag-common-vs-contact-issue-on-currently-running-activepublished-journeys-and-events branch September 11, 2024 16:05
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/event COMPONENT c/journey COMPONENT
Projects
None yet
Milestone
7.4.1
Development

Successfully merging this pull request may close these issues.

[BUG] dont flag common vs contact issue on currently running (active/published) journeys and events
1 participant
@JoernBerkefeld