Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/1614 speed up multi-key deletes & equalize delete-errors #1615

Merged

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 28, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld self-assigned this Aug 28, 2024
@JoernBerkefeld JoernBerkefeld linked an issue Aug 28, 2024 that may be closed by this pull request
@JoernBerkefeld JoernBerkefeld added this to the 7.2.1 milestone Aug 28, 2024
@github-actions github-actions bot added the chore Jira issue-type "Task" label Aug 28, 2024
@JoernBerkefeld JoernBerkefeld added c/automation COMPONENT c/dataExtract COMPONENT c/importFile COMPONENT c/query COMPONENT c/script COMPONENT c/fileTransfer COMPONENT c/mobileKeyword COMPONENT c/asset COMPONENT labels Aug 28, 2024
Copy link

github-actions bot commented Aug 28, 2024

Coverage Report

Commit:ea2b056
Base: develop@0fe4111

Type Base This PR
Total Statements Coverage  71.29%  71.29%  (+0%)
Total Branches Coverage  69.67%  69.69%  (+0.02%)
Total Functions Coverage  82.9%  82.9%  (+0%)
Total Lines Coverage  71.29%  71.29%  (+0%)
Details (changed files):
File Statements Branches Functions Lines
lib/index.js  72.72%  65.97%  73.8%  72.72%
lib/metadataTypes/Asset.js  78.28%  67.53%  89.36%  78.28%
lib/metadataTypes/Automation.js  80.73%  63.8%  94.44%  80.73%
lib/metadataTypes/DataExtract.js  91.17%  54.54%  100%  91.17%
lib/metadataTypes/FileTransfer.js  89.42%  52.17%  100%  89.42%
lib/metadataTypes/ImportFile.js  69.73%  60.86%  100%  69.73%
lib/metadataTypes/MetadataType.js  82.57%  79.9%  77.21%  82.57%
lib/metadataTypes/MobileKeyword.js  88.98%  77.19%  90.9%  88.98%
lib/metadataTypes/Query.js  95.54%  87.5%  100%  95.54%
lib/metadataTypes/Script.js  97.43%  79.06%  100%  97.43%

@JoernBerkefeld JoernBerkefeld merged commit 1dd845f into develop Aug 28, 2024
11 checks passed
@JoernBerkefeld JoernBerkefeld deleted the task/1614-speed-up-multi-typekey-deletion-logic branch August 28, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/asset COMPONENT c/automation COMPONENT c/dataExtract COMPONENT c/fileTransfer COMPONENT c/importFile COMPONENT c/mobileKeyword COMPONENT c/query COMPONENT c/script COMPONENT chore Jira issue-type "Task"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] speed up multi-type/key deletion logic
1 participant