Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1139: allow specifying the email ID directly in emailSends #1175

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Jan 17, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added the c/emailSend COMPONENT label Jan 17, 2024
@JoernBerkefeld JoernBerkefeld added this to the 6.0.2 milestone Jan 17, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 17, 2024
@github-actions github-actions bot added the bug Something isn't working label Jan 17, 2024
@JoernBerkefeld JoernBerkefeld changed the title Bugfix/1139: allow specifying the email ID directly as a fallback option Bugfix/1139: allow specifying the email ID directly in emailSends Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

Coverage Report

Commit:d9b92f0
Base: develop@db253e7

Type Base This PR
Total Statements Coverage  64.34%  64.25%  (-0.09%)
Total Branches Coverage  67.23%  67.21%  (-0.02%)
Total Functions Coverage  73.35%  73.48%  (+0.13%)
Total Lines Coverage  64.34%  64.25%  (-0.09%)
Details (changed files):
File Statements Branches Functions Lines

@JoernBerkefeld JoernBerkefeld merged commit 88a2740 into develop Jan 17, 2024
5 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/1139-emailsend-activity-deployment-error-when-emailid-is-in-json branch January 17, 2024 15:09
@JoernBerkefeld JoernBerkefeld linked an issue Jan 17, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/emailSend COMPONENT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] emailSend activity deployment error when Email.ID is in JSON
1 participant