Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/940 fields added to shared data extension are not visible in child business unit data designer #1074

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented Aug 11, 2023

PR details

What changes did you make? (Give an overview)

image

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (via [TASK] Documentation for 5.3 #1081)

@JoernBerkefeld JoernBerkefeld added this to the 5.2.1 milestone Aug 11, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Aug 11, 2023
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2023
@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Coverage Report

Commit:fbb9963
Base: develop@697f7cb

Type Base This PR
Total Statements Coverage  52.16%  54.66%  (+2.5%)
Total Branches Coverage  41.96%  43.77%  (+1.81%)
Total Functions Coverage  61.1%  63.76%  (+2.66%)
Total Lines Coverage  52.07%  54.59%  (+2.52%)
Details (changed files):
File Statements Branches Functions Lines
lib/cli.js  0%  0%  0%  0%
lib/index.js  55.08%  47.36%  57.69%  54.98%
lib/metadataTypes/AttributeSet.js  86.32%  71.66%  100%  86.2%
lib/metadataTypes/DataExtension.js  73.62%  59.68%  88.46%  73.81%
lib/metadataTypes/DataExtensionField.js  76.14%  62.26%  91.66%  75.92%

@JoernBerkefeld
Copy link
Contributor Author

2023-08-11T14:46:46.2506625Z 14:46:46 �[36mverbose�[39m: MetadataType[attributeSet].deleteFieldByDefinition[retrieving]:: Field dataRetentionProperties.periodLength not in metadata info

@JoernBerkefeld
Copy link
Contributor Author

Documentation update pending

@JoernBerkefeld
Copy link
Contributor Author

Add support for preselect all BUs (*)

@JoernBerkefeld
Copy link
Contributor Author

udpate warning about missing --fixShared to explain that rerunning the deploy command WITH the option will do the trick

@JoernBerkefeld JoernBerkefeld added enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story" and removed bug Something isn't working labels Aug 16, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.2.1, 5.3.0 Aug 16, 2023
@JoernBerkefeld JoernBerkefeld changed the title Bugfix/940 fields added to shared data extension are not visible in child business unit data designer Feature/940 fields added to shared data extension are not visible in child business unit data designer Aug 16, 2023
@JoernBerkefeld
Copy link
Contributor Author

to identify BUs, maybe we should check the attributeSet's field list and compare it with the Shared DE? The idea being, that if things are already fine, nothing needs to be fixed?

@JoernBerkefeld JoernBerkefeld merged commit e6852dd into develop Aug 17, 2023
4 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bugfix/940-fields-added-to-shared-data-extension-are-not-visible-in-child-business-unit-data-designer branch August 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/dataExtension COMPONENT enhancement New feature or request; requires increasing the minor version of mcdev. Jira issue-type "Story"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Fields added to Shared Data Extension are not visible in child Business Unit Data Designer
1 participant