#1738: skip re-retrieve if all publish actions failed

Accenture · Sep 26, 2024 · d3e9479 · d3e9479
1 parent a10addb
commit d3e9479
Showing 1 changed file with 33 additions and 30 deletions.
diff --git a/lib/metadataTypes/Journey.js b/lib/metadataTypes/Journey.js
@@ -1856,41 +1856,44 @@ class Journey extends MetadataType {
             }).start();
             const transactionalKeyArr = (await Promise.all(resultsTransactional)).filter(Boolean);
             spinner.success('done.');
-            executedKeyArr.push(...transactionalKeyArr);
 
-            Util.logger.info('Retrieving relevant journeys');
-            const retriever = new Retriever(this.properties, this.buObject);
+            // if all publish actions failed, we don't need to re-retrieve anything here
+            if (transactionalKeyArr.length) {
+                executedKeyArr.push(...transactionalKeyArr);
 
-            try {
-                const updatedJourneyRetrieve = await retriever.retrieve(
-                    ['journey'],
-                    transactionalKeyArr
-                );
+                Util.logger.info('Retrieving relevant journeys');
+                const retriever = new Retriever(this.properties, this.buObject);
 
-                /** @type {MetadataTypeItem[]} */
-                const updatedJourneys = Object.values(updatedJourneyRetrieve?.journey[0]);
-                if (updatedJourneys) {
-                    const updatedTransactionalEmails = [];
-                    for (const journey of updatedJourneys) {
-                        updatedTransactionalEmails.push(
-                            journey.activities?.[0]?.configurationArguments
-                                ?.r__transactionalEmail_key
-                        );
-                    }
-                    if (updatedTransactionalEmails.filter(Boolean).length) {
-                        Util.logger.info('Retrieving relevant transactionalEmails');
-                        await retriever.retrieve(
-                            ['transactionalEmail'],
-                            updatedTransactionalEmails.filter(Boolean)
-                        );
-                    } else {
-                        Util.logger.error(
-                            `Could not find transactional Emails for the published journeys`
-                        );
+                try {
+                    const updatedJourneyRetrieve = await retriever.retrieve(
+                        ['journey'],
+                        transactionalKeyArr
+                    );
+                    /** @type {MetadataTypeItem[]} */
+                    const updatedJourneys = Object.values(updatedJourneyRetrieve?.journey[0]);
+                    if (updatedJourneys) {
+                        const updatedTransactionalEmails = [];
+                        for (const journey of updatedJourneys) {
+                            updatedTransactionalEmails.push(
+                                journey.activities?.[0]?.configurationArguments
+                                    ?.r__transactionalEmail_key
+                            );
+                        }
+                        if (updatedTransactionalEmails.filter(Boolean).length) {
+                            Util.logger.info('Retrieving relevant transactionalEmails');
+                            await retriever.retrieve(
+                                ['transactionalEmail'],
+                                updatedTransactionalEmails.filter(Boolean)
+                            );
+                        } else {
+                            Util.logger.error(
+                                `Could not find transactional Emails for the published journeys`
+                            );
+                        }
                     }
+                } catch (ex) {
+                    Util.logger.errorStack(ex, 'retrieve failed');
                 }
-            } catch (ex) {
-                Util.logger.errorStack(ex, 'retrieve failed');
             }
         }
         Util.logger.info(