Skip to content

Commit

Permalink
#1522: support double-array of markets in marketLists / buildDefiniti…
Browse files Browse the repository at this point in the history
…onBulk
  • Loading branch information
JoernBerkefeld committed Aug 28, 2024
1 parent acc06b9 commit 978daef
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 17 deletions.
2 changes: 1 addition & 1 deletion @types/lib/Builder.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 19 additions & 16 deletions lib/Builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,25 +249,28 @@ saved
continue;
}
i++;
/** @type {string | string[] | string[][]} */
const market = properties.marketList[listName][businessUnit];
let marketList = [];
if ('string' === typeof market) {
marketList.push(market);
} else {
marketList = market;
}
const marketList = 'string' === typeof market ? [market] : market;

for (const market of marketList) {
if (Util.checkMarket(market, properties)) {
Util.logger.info(`Executing for '${businessUnit}': '${market}'`);
// omitting "await" to speed up creation
responseObj[businessUnit] ||= {};
responseObj[businessUnit][market] = await this.buildDefinition(
businessUnit,
type,
nameArr,
market
);
// one can now send multiple markets to buildTemplate/buildDefinition and hence that also needs to work for marketLists
const marketArr = 'string' === typeof market ? [market] : market;
for (const market of marketArr) {
if (!Util.checkMarket(market, properties)) {
return;
}
}

Util.logger.info(`Executing for '${businessUnit}': '${marketArr.join('-')}'`);
// omitting "await" to speed up creation
responseObj[businessUnit] ||= {};
responseObj[businessUnit][marketArr.join('-')] = await this.buildDefinition(
businessUnit,
type,
nameArr,
marketArr
);
}
}

Expand Down

0 comments on commit 978daef

Please sign in to comment.