Toggle LDAP/ACL #40
Toggle LDAP/ACL #40
Conversation
RobertNorthard
force-pushed
the
feature/adop-acl-toggle
branch
from
13151d6
to
292cdd0
Compare
| } | ||
| credentialsBinding { | ||
| usernamePassword("LDAP_ADMIN_USER", "LDAP_ADMIN_PASSWORD", "adop-ldap-admin") | ||
| if("${ADOP_LDAP_ENABLED}" == "true") |
There was a problem hiding this comment.
This variable ADOP_LDAP_ENABLED needs to appear:
a) In the compose file for jenkins
b) Injected as a global env variable here: https://github.com/Accenture/adop-jenkins/blob/master/resources/init.groovy.d/adop_general.groovy
There was a problem hiding this comment.
- It'll also need the ACL env variable defined in the compose file and injected.
- Strings should also use content rather than reference equality.
RobertNorthard
force-pushed
the
feature/adop-acl-toggle
branch
4 times, most recently
from
41d55e2
to
1bc4911
Compare
|
I'm wondering if we should flip the logic in the interest of backwards compatibility? If someone is on an older version of the Jenkins image they won't have the environment variables which means the jobs will be generated with sections missing and it won't be obvious why. |
| ${WORKSPACE}/common/gerrit/create_user.sh -g http://gerrit:8080/gerrit -u "${username}" -p "${username}" | ||
| done''') | ||
| dsl { | ||
| external("workspaces/jobs/**/*.groovy") |
workspaces/jobs/jobs.groovy
Outdated
| # Generate second permission repo with enabled code-review | ||
| source ${WORKSPACE}/projects/gerrit/configure.sh -r permissions-with-review''') | ||
| dsl { | ||
| external("projects/jobs/**/*.groovy") |
RobertNorthard
force-pushed
the
feature/adop-acl-toggle
branch
5 times, most recently
from
0449df1
to
c6113bf
Compare
|
PR submitted for Load_Platform to read global variables instead of environment variables: Going to test ACL/LDAP toggling. |
RobertNorthard
force-pushed
the
feature/adop-acl-toggle
branch
2 times, most recently
from
d5b806b
to
97a827b
Compare
RobertNorthard
force-pushed
the
feature/adop-acl-toggle
branch
from
c947f66
to
8558f08
Compare
|
I have tested the following scenarios.
The ADOP LDAP environment variable is set in the adop-docker-compose for Jenkins. This PR can be merged on it's own. |
Conditional steps for LDAP is it modifiable or not.
|
@SachinKSingh28 I've merged Maris changes so this will need another review. |
As a platform user,
I want to be able to toggle ACL.
This is dependent on
ADOP_ACL_ENABLEDenvironment variable for adop-docker-compose for Jenkins.Dependent on;
Inject ADOP LDAP and ACL enabled environment variables. adop-jenkins#35Updated Jenkins image to 0.2.5 adop-docker-compose#194