Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker-based platform support to Load_Platform_Extension Jenkins job. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RobertNorthard
Copy link
Contributor

@RobertNorthard RobertNorthard commented Sep 16, 2016

  • Added support for docker-based platform extensions.

Dependent on

@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch 10 times, most recently from e6b2ee2 to 19c001d Compare September 17, 2016 14:46
@RobertNorthard RobertNorthard changed the title [WIP] - Updated Load_Platform_Extension and Collection job to support docker-based platform extensions Updated Load_Platform_Extension and Collection job to support docker-based platform extensions Sep 17, 2016
@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch from 19c001d to 93e9d38 Compare September 17, 2016 14:48
@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch from 93e9d38 to 1b18364 Compare September 19, 2016 16:32
@RobertNorthard RobertNorthard changed the title Updated Load_Platform_Extension and Collection job to support docker-based platform extensions Added docker-based platform support to Load_Platform_Extension Jenkins job. Sep 19, 2016
@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch 3 times, most recently from b329850 to a5a65a4 Compare September 26, 2016 12:52
@RobertNorthard
Copy link
Contributor Author

Based on @kramos feedback added a guard to check if the service extension proxy configuration deployment method is supported.

This also raises a question about managing dependencies between platman, cartridges, platform extensions and ADOP core. I have raised Issue #24 as a place to discuss this.

@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch from a5a65a4 to 3bda1b0 Compare September 26, 2016 14:07
@fethiozdol
Copy link

Hi, one suggestion:
if the a docker container with the same tag already exists, platform extension job should halt?

    if docker ps | tail -n +1 | rev | cut -d' ' -f 1 | rev | grep -q ${PLATFORM_EXTENSION_NAME}; then
      echo "#######################################"
      echo "ERROR: Extension \"${PLATFORM_EXTENSION_NAME}\" already exists!"
      exit 1
    fi

@RobertNorthard
Copy link
Contributor Author

Thanks @fethiozdol. Docker-compose will fail saying that the container already exists, but no harm in being more explicit.

@RobertNorthard RobertNorthard force-pushed the feature/support-docker-based-platform-extensions branch from 3bda1b0 to 5690bd7 Compare November 5, 2016 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants