Adding OWASP Dependency Check job #34
Conversation
Adding Owasp Dependency Check job Adding test for Owasp Dependency Check job Improving .gitignore
|
Hi @kramos , excellent additional to the pipeline! I've found that "Publishes OWASP dependency check results" supported by JobDSL by default, so not need to make configure fallback block there, you can reduce source code there and make it more convenient. |
| } | ||
| } | ||
|
|
||
| configure { project -> |
There was a problem hiding this comment.
We can replace this with DSL, instead of just XML fallback https://jenkinsci.github.io/job-dsl-plugin/#method/javaposse.jobdsl.dsl.helpers.publisher.PublisherContext.dependencyCheck
|
Good find @anton-kasperovich I replaced the publisher XML with DSL and tested it. Thanks for the tip on searching the DSL plugin source code for DSL support, e.g. https://github.com/jenkinsci/job-dsl-plugin/search?utf8=%E2%9C%93&q=dependencyCheck |
|
Here is a PR for the Jenkins update: |
|
Tested this in a vanilla latest ADOP and
|
|
OWASP_Dependency_Check job tested and working with and without setting threshold. |
|
is there any outstanding issue preventing us from merging this? it would be great to have in Java cartridge by default. |
Also:
Adding test for Owasp Dependency Check job
Fixing #33
Improving .gitignore
This PR is dependent on the docker image created by this PR:
Accenture/adop-jenkins#25
being tagged and consumed by an updated:
https://github.com/Accenture/adop-docker-compose/blob/master/docker-compose.yml