Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oracle.rs #2820

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update oracle.rs #2820

merged 1 commit into from
Oct 17, 2024

Conversation

zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Oct 17, 2024

In the ERC20 interface, the maximum number of decimals is 18, but it is better to use saturating_sub

In the ERC20 interface, the maximum number of decimals is 18, but it is better to use `saturating_sub`
@zjb0807 zjb0807 requested a review from xlc October 17, 2024 02:10
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (8c19bd7) to head (50f79fc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
- Coverage   61.88%   61.80%   -0.09%     
==========================================
  Files          68       67       -1     
  Lines        9936     9265     -671     
==========================================
- Hits         6149     5726     -423     
+ Misses       3787     3539     -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjb0807 zjb0807 merged commit f79aa2b into master Oct 17, 2024
7 checks passed
@zjb0807 zjb0807 deleted the zjb0807-patch-1 branch October 17, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants