-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RootNode and InternalNode Probe Methods #1936
Merged
danrbailey
merged 5 commits into
AcademySoftwareFoundation:feature/tree_api_tests
from
danrbailey:tree_api_probe
Oct 29, 2024
Merged
RootNode and InternalNode Probe Methods #1936
danrbailey
merged 5 commits into
AcademySoftwareFoundation:feature/tree_api_tests
from
danrbailey:tree_api_probe
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Bailey <[email protected]>
Signed-off-by: Dan Bailey <[email protected]>
danrbailey
requested review from
kmuseth,
apradhana,
jmlait,
Idclip and
richhones
as code owners
October 18, 2024 05:21
Signed-off-by: Dan Bailey <[email protected]>
danrbailey
force-pushed
the
tree_api_probe
branch
from
October 21, 2024 20:28
a51067b
to
fb7384b
Compare
Signed-off-by: Dan Bailey <[email protected]>
kmuseth
requested changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see omments
Signed-off-by: Dan Bailey <[email protected]>
Addressed all the feedback in this PR, thanks! |
kmuseth
approved these changes
Oct 29, 2024
danrbailey
merged commit Oct 29, 2024
57d4201
into
AcademySoftwareFoundation:feature/tree_api_tests
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of new "probe" methods to fill in some gaps in the API in being able to query child nodes as well as adds some additional convenience methods.
RootNode
The root node adds convenience methods to query the child nodes (as opposed to needing to supply a template parameter
probeNode<ChildT>(const Coord&)
). In addition, there are newprobe()
methods that query whether a key exists (and returns false if not) and returns either a child node or a value and active state otherwise. Finally, a templatedprobeNode()
method that can be called on a const RootNode has been added.Here are all the new RootNode methods:
InternalNode
The internal node adds convenience methods to query the child nodes (as opposed to needing to supply a template parameter
probeNode<ChildT>(const Coord&)
). In addition, there are also methods that allow querying from an offset (and ensures the offset is not out-of-bounds) as well as being able to pass in value and active state reference variables that are populated if a child node is not present. Finally, a templatedprobeNode()
method that can be called on a const InternalNode has been added.Here are all the new InternalNode methods: