Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fVDB CI setup #1908

Draft
wants to merge 21 commits into
base: feature/fvdb
Choose a base branch
from

Conversation

swahtz
Copy link
Contributor

@swahtz swahtz commented Sep 18, 2024

No description provided.

Signed-off-by: Jonathan Swartz <[email protected]>
fvdb printing debug info

Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
@swahtz
Copy link
Contributor Author

swahtz commented Sep 18, 2024

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

@danrbailey
Copy link
Contributor

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

@swahtz
Copy link
Contributor Author

swahtz commented Sep 19, 2024

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

Oh yes, that is a mistake... a slight mismatch in the changes I was making. I'll make sure to fix that up.

Revert accidental change to ax workflow ignore-paths

Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
Signed-off-by: Jonathan Swartz <[email protected]>
@swahtz swahtz marked this pull request as draft October 21, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants