Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Redundant Render Function Call #1686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ganesh1828
Copy link

@ganesh1828 ganesh1828 commented Oct 13, 2023

Due to mUpdates upper limit value check 2, render function is called twice from the loop in the view function in the Viewer.cc file.
Changing its upper limit value check to 1 will results in calling render function only once.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023

CLA Not Signed

Signed-off-by: Ganesh Suresh Kandepalli <[email protected]>
@diiigle
Copy link

diiigle commented Oct 14, 2023

Rings some alarm bells for me:

  1. effectively a 1 line change, that would be "easy to approve"
  2. no description provided
  3. Why is there a binary blob committed, and then removed in a second commit? Just to place it in the history?!

smells fishy

@ganesh1828
Copy link
Author

@diiigle Binary was pushed by mistake, that's why I removed it. and description is provided now, you can check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants