Fix macOS and Windows build failures when threading is disabled #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses AcademySoftwareFoundation#1455 The logic around which implementation of the IlmThread::Semaphore class to use is now consolidated into the block of code that deciphers the platform and specifies the #includes, rather than spread across multiple files. Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
Signed-off-by: Cary Phillips <[email protected]>
meshula
approved these changes
Jun 23, 2023
kdt3rd
approved these changes
Jun 26, 2023
cary-ilm
added a commit
to cary-ilm/openexr
that referenced
this pull request
Jul 25, 2023
…emySoftwareFoundation#1462) * Fix macOS and Windows build failures when threading is disabled Addresses AcademySoftwareFoundation#1455 The logic around which implementation of the IlmThread::Semaphore class to use is now consolidated into the block of code that deciphers the platform and specifies the #includes, rather than spread across multiple files. Signed-off-by: Cary Phillips <[email protected]> * Add macOS/Windows builds with threading disabled Signed-off-by: Cary Phillips <[email protected]> * Fix typo with ILMTHREAD_SEMAPHORE_OTHER, and add missing macOS includes Signed-off-by: Cary Phillips <[email protected]> * Add threads-enabled='ON' so it shows up in the job name Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
cary-ilm
added a commit
that referenced
this pull request
Jul 31, 2023
* Fix macOS and Windows build failures when threading is disabled Addresses #1455 The logic around which implementation of the IlmThread::Semaphore class to use is now consolidated into the block of code that deciphers the platform and specifies the #includes, rather than spread across multiple files. Signed-off-by: Cary Phillips <[email protected]> * Add macOS/Windows builds with threading disabled Signed-off-by: Cary Phillips <[email protected]> * Fix typo with ILMTHREAD_SEMAPHORE_OTHER, and add missing macOS includes Signed-off-by: Cary Phillips <[email protected]> * Add threads-enabled='ON' so it shows up in the job name Signed-off-by: Cary Phillips <[email protected]> --------- Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1455
The logic around which implementation of the
IlmThread::Semaphoreclass to use is now consolidated into the block of code that deciphers the platform and specifies the #includes, rather than spread across multiple files.This also adds macOS and Windows CI jobs with threading disabled.
The previous logic was completely broken for the macOS case, where it would produce duplicate implementations in
IlmThreadSemaphore.cppand inIlmThreadSemaphoreOSX.cppwhen threading is disabled.Please do what you can to confirm that this logic looks correct for all platforms, since it's not completely clear to me that the test suite will reliably fail if the logic is off.