Updated Effect schema with enabled flag

[fschleich]

This PR addresses #1187 - Add enabled Flag to Effects

If there is an associated issue, link it in the form:

Fixes #1187

Summarize your change.

• Added enabled flag to Effect schema
  - Updated Effect schema to version 2
  - Updated core version to 0.18.0

Reference associated tests.

• Updated unit tests in test_effect.py to account for enabled flag
• added empty_effect.json and updated test_json_backend.py accordingly

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fschleich / name: Florian Schleich (334bf4c, c2ab22f, 3cb9733)

[fschleich]

I need some guidance on how to correctly update CORE_VERSION_MAP.cpp, as running make version-map-update results in the below error. Manually setting the version to 0.18.0 results in the failed tests, e.g. here. Would appreciate any pointers or guidance!

(.venv) fschleich@Florians-MacBook-Pro OpenTimelineIO % make version-map-update
updating the CORE_VERSION_MAP...
Traceback (most recent call last):
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 116, in <module>
    main()
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 86, in main
    args = _parsed_args()
           ^^^^^^^^^^^^^^
  File "/Users/fschleich/Developer/github/fschleich/OpenTimelineIO/src/py-opentimelineio/opentimelineio/console/autogen_version_map.py", line 38, in _parsed_args
    default=otio.__version__,
            ^^^^^^^^^^^^^^^^
AttributeError: module 'opentimelineio' has no attribute '__version__'
make: *** [version-map-update] Error 1

[jminor]

A while back when we added enabled to Clip, we were able to do so without increasing the schema version because the new property has a clear fallback value (true). I think you can do the same here for Effect. Here's the PR for Clip for reference: #1175

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (c0e97b0) to head (c2ab22f).
Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/opentimelineio/effect.h	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   84.11%   81.62%   -2.50%     
==========================================
  Files         198      176      -22     
  Lines       22241    12350    -9891     
  Branches     4687     3036    -1651     
==========================================
- Hits        18709    10081    -8628     
+ Misses       2610     1730     -880     
+ Partials      922      539     -383     

Flag	Coverage Δ
py-unittests	81.62% <94.73%> (-2.50%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/opentimelineio/effect.cpp	93.33% <100.00%> (+1.66%)	⬆️
...entimelineio-bindings/otio_serializableObjects.cpp	93.69% <100.00%> (-0.17%)	⬇️
.../py-opentimelineio/opentimelineio/schema/effect.py	100.00% <ø> (ø)
tests/test_effect.py	96.42% <100.00%> (+0.35%)	⬆️
tests/test_json_backend.py	93.65% <100.00%> (+0.20%)	⬆️
src/opentimelineio/effect.h	80.00% <50.00%> (-20.00%)	⬇️

... and 65 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5184c36...c2ab22f. Read the comment docs.

[reinecke]

Looks great - thanks for the update!