Added fix for pip._vendor.distlib issue on windows msys2 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
reinecke
force-pushed
the
fix-msys2-builds
branch
from
75ac93f to
21b958e
Compare
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Signed-off-by: Eric Reinecke <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
==========================================
+ Coverage 79.95% 84.07% +4.11%
==========================================
Files 197 198 +1
Lines 21879 22172 +293
Branches 4342 4687 +345
==========================================
+ Hits 17494 18641 +1147
- Misses 2252 2609 +357
+ Partials 2133 922 -1211
Flags with carried forward coverage won't be shown. Click here to find out more. see 165 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
apetrynet
approved these changes
Jun 12, 2024
|
Wow, congratulations on figuring this one out!!! |
darbyjohnston
pushed a commit
to darbyjohnston/OpenTimelineIO
that referenced
this pull request
Jun 14, 2024
…wareFoundation#1762) Added fix for pip._vendor.distlib issue on windows msys2 Signed-off-by: Eric Reinecke <[email protected]> Signed-off-by: Darby Johnston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1757
Summarize your change.
Added step to force pip update in msys2 based on these directions.