Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum OS X deployment version to 10.14 #1719

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

darbyjohnston
Copy link
Contributor

Fixes #1718

Compiling the latest OTIO with C++17 support gives this error on macOS 10.15.7:

'any_cast<const opentimelineio::v1_0::AnyVector &>' is unavailable: introduced in macOS 10.14
AnyVector const& av = std::any_cast<AnyVector const&>(source);
^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/any:581:12: note:
'any_cast<const opentimelineio::v1_0::AnyVector &>' has been explicitly marked unavailable here

Bumping CMAKE_OSX_DEPLOYMENT_TARGET to 10.14 fixes the issue.

Signed-off-by: Darby Johnston <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (82068e3) to head (9c434c6).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   79.96%   79.95%   -0.02%     
==========================================
  Files         197      197              
  Lines       21867    21879      +12     
  Branches     4338     4342       +4     
==========================================
+ Hits        17487    17494       +7     
- Misses       2249     2252       +3     
- Partials     2131     2133       +2     
Flag Coverage Δ
py-unittests 79.95% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82068e3...9c434c6. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

@reinecke reinecke added this to the Public Beta 17 milestone Apr 11, 2024
@meshula meshula merged commit 8cf4a31 into AcademySoftwareFoundation:main Apr 18, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set minimum OS X deployment version to 10.14
4 participants