Added support for custom adapter hooks #1711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## extract_adapters #1711 +/- ##
====================================================
+ Coverage 74.16% 74.20% +0.04%
====================================================
Files 175 176 +1
Lines 12056 12091 +35
Branches 2789 2794 +5
====================================================
+ Hits 8941 8972 +31
- Misses 1356 1358 +2
- Partials 1759 1761 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
@ssteinbach If you could have a look at this sometime, that'd be wonderful. See OpenTimelineIO/otio-aaf-adapter#43 for why this is needed. |
…SoftwareFoundation#1488) * add "extract_adapters" to CI triggers * use "otiod" as override example Signed-off-by: apetrynet <[email protected]>
…oftwareFoundation#1487) * Removed the cmx_3600 adapter * Removed sample data only used by the cmx_3600 adapter * Add "extract_adapters" to CI triggers * otioz test called for an edl we removed. Replaced with an otio file * Converted screening_example.edl to screening_example.otio and used it in tests * Removed other adapter suffixes from plugin tests as they belong to adapters soon to be extracted * Autogenerated docs for CMX3600 removed Signed-off-by: apetrynet <[email protected]>
…cademySoftwareFoundation#1348) * Remove AAF adapter * Add Note about the AAF adapter being moved Signed-off-by: Mark Reid <[email protected]>
* removing the fcp adapter and it's test files * replaced premiere_example.xml with premiere_example.otio to pass console tests. * updated auto generated docs Signed-off-by: apetrynet <[email protected]>
* removed svg adapter and related test files * updated auto documentation Signed-off-by: apetrynet <[email protected]>
…n#1520) * Remove maya adapter related files * Update docs Signed-off-by: rosborne132 <[email protected]>
* remove fcp x xml adapter files * update docs Signed-off-by: rosborne132 <[email protected]>
Signed-off-by: rosborne132 <[email protected]>
* remove ale adapter related files Signed-off-by: rosborne132 <[email protected]>
* extract burnin files * remove test Signed-off-by: rosborne132 <[email protected]>
* extract xges adapter files Signed-off-by: rosborne132 <[email protected]>
* Removed the "contrib" directory tree and all references to the contrib adapters. * Plugin system, setup and auto doc scripts no longer rely on contrib files. * Also removed some entries on other adapters left behind in the adapters.md file. * add README_contrib.md to the manifest Signed-off-by: apetrynet <[email protected]>
…emySoftwareFoundation#1644) Signed-off-by: Tim Lehr <[email protected]>
…tions (AcademySoftwareFoundation#1704) Signed-off-by: Tim Lehr <[email protected]>
|
@timlehr Can you switch the base branch in this PR to the new |
timlehr
changed the base branch from
extract_adapters
to
extract_adapters_post_beta_16
This adds support for attributing custom hooks to adapters and executing them with `hook_function_argument_map` being passed along through the adapter IO functions. Signed-off-by: Tim Lehr <[email protected]>
timlehr
force-pushed
the
adapterHooks_tlehr
branch
from
f6b309e to
31c51db
Compare
|
@reinecke Just rebased the code! |
reinecke
force-pushed
the
extract_adapters_post_beta_16
branch
2 times, most recently
from
fbe098e to
7f09945
Compare
|
@ssteinbach Seems like there were force-pushes to the |
reinecke
force-pushed
the
extract_adapters_post_beta_16
branch
2 times, most recently
from
96a5a1a to
58b11c7
Compare
reinecke
force-pushed
the
extract_adapters_post_beta_16
branch
from
9d33bd3 to
b052e57
Compare
reinecke
deleted the branch
AcademySoftwareFoundation:extract_adapters_post_beta_16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
This adds support for attributing custom hooks to adapters and executing them with
hook_function_argument_mapbeing passed along through the adapter IO functions.Describe the reason for the change.
I added two custom hooks to the OTIO AAF adapter (OpenTimelineIO/otio-aaf-adapter#43), allowing for embedding of media essence into the resulting AAF. This was needed to facilitate just-in-time DNXHR transcoding of the media for the AAF creation and adding a certain level of control and flexibility to the feature.
These features to the core are required in order to properly pass the hook argument map along to potential custom hooks run by the adapter. I tried to work with
_FEATURE_MAPinstead of creating a new version of the Adapter schema in order to minimize the impact of this change, while adding the necessary changes to facilitate custom hooks for adapters.Reference associated tests.