-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize track lengths with gaps before flatten stacks #1703
Normalize track lengths with gaps before flatten stacks #1703
Conversation
fixes AcademySoftwareFoundation#1430 Signed-off-by: Mark Reid <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
- Coverage 79.83% 79.76% -0.08%
==========================================
Files 197 197
Lines 21814 21846 +32
Branches 4362 4380 +18
==========================================
+ Hits 17416 17425 +9
- Misses 2233 2246 +13
- Partials 2165 2175 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left some requests for comments in a few places. Overall it looks correct to me.
Renamed track variables in normalized_tracks_lengths to be more clear. Signed-off-by: Mark Reid <[email protected]>
I think I addressed your notes. please take a look when you get a chance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Mark!
This PR fixes #1430
I added a
_normalize_tracks_lengths
function that adds gap items to the end of tracks that are shorter before the flattening happens.