Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize track lengths with gaps before flatten stacks #1703

Merged

Conversation

markreidvfx
Copy link
Contributor

This PR fixes #1430

I added a _normalize_tracks_lengths function that adds gap items to the end of tracks that are shorter before the flattening happens.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 79.76%. Comparing base (013fe04) to head (d5430bd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1703      +/-   ##
==========================================
- Coverage   79.83%   79.76%   -0.08%     
==========================================
  Files         197      197              
  Lines       21814    21846      +32     
  Branches     4362     4380      +18     
==========================================
+ Hits        17416    17425       +9     
- Misses       2233     2246      +13     
- Partials     2165     2175      +10     
Flag Coverage Δ
py-unittests 79.76% <30.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/opentimelineio/stackAlgorithm.cpp 28.71% <30.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013fe04...d5430bd. Read the comment docs.

@reinecke reinecke added this to the Public Beta 16 milestone Mar 14, 2024
Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some requests for comments in a few places. Overall it looks correct to me.

src/opentimelineio/stackAlgorithm.cpp Outdated Show resolved Hide resolved
src/opentimelineio/stackAlgorithm.cpp Show resolved Hide resolved
src/opentimelineio/stackAlgorithm.cpp Outdated Show resolved Hide resolved
Renamed track variables in normalized_tracks_lengths to be more clear.

Signed-off-by: Mark Reid <[email protected]>
@markreidvfx
Copy link
Contributor Author

I think I addressed your notes. please take a look when you get a chance :)

@markreidvfx markreidvfx requested a review from jminor March 15, 2024 05:45
Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Mark!

@jminor jminor merged commit 665c482 into AcademySoftwareFoundation:main Mar 15, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatten stack produces undesirable results if track does not end with gap or clip
4 participants