-
Notifications
You must be signed in to change notification settings - Fork 629
deps: Add build recipe for GIF #4653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
deps: Add build recipe for GIF #4653
Conversation
Signed-off-by: Sergio Rojas <[email protected]>
5d3962a
to
34ba540
Compare
How did you test this and verify that it works? |
I'm still working on the pull request - Here's what I'm currently doing to test and verify the CMake files:
This makes CMake to build all dependencies locally instead of using system-installed versions. |
Another way to test and verify:
a. Converting an image to GIF format: b. You can also try to convert a GIF to another format to further verify that it's working: |
src/cmake/build_gif.cmake
Outdated
PATCH_COMMAND | ||
curl -L https://sourceforge.net/p/giflib/bugs/_discuss/thread/4e811ad29b/c323/attachment/Makefile.patch -o Makefile.patch && | ||
patch -p0 < Makefile.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be bothered by the fact that the build_dependency_with_cmake
function doesn't take a "PATCH_COMMAND" argument, and so this extra patch won't be applied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, build_dependency_with_cmake doesn't take a URL or URL_HASH argument, and in fact the only kind of download it knows how to do is to clone a git repo? I just don't understand how the code as presented here can work.
Are you sure you aren't locally running and testing a version of this patch that is different from the one currently in this PR?
This hypothesis is also supported by the fact that the screenshots you attached have messages about FetchContent, which we do not call anywhere and also aren't mentioned in this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just realized I forgot to push my latest change where I removed the build_dependency_with_cmake method since it only accepts a git repository
fdd1f0c
to
0f7a559
Compare
Description
As requested in #4387.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.