Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename response_length to response_size #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rghvdberg
Copy link

The docs https://www.shadowserver.org/what-we-do/network-reporting/open-ms-sql-server-resolution-service-report/ state
that there's a field called response_length, however in de sample at the bottom of the page and in the csv report we received the field is named response_size.

@kruisdraad
Copy link
Member

rejected change

although it makes sense now, the field was other in the past. IF you ever want to add old reports back it would fail. This is why we have ALIAS method inside the definition. Have a look at the botnet_drone currently configured. This way both old and new will still work. Please update your PR to be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants