Optimize message status updates

[mirgee]

Currently, message handling of type UPDATE_MSG_STATUS_BY_CONNS is highly inefficient. It takes a list of pairs of pwDids of the agent connection corresponding to the message to be updated and a list of uids of the messages to be updated (along with the status code to be assigned):

[{"pairwiseDID":"Fp4eVWcjyRawjNWgnJmJWD","uids":["b7vh36XiTe"]}]

In order to perform the update, this argument is converted to a format such that each agent connection pwDid is converted to an agent connection did, querying the database potentially multiple times in the process.

Moreover, in order to construct the response containing updated and failed-to-update lists of pairs in the same format described above, it performs an inverse conversion using the same inefficient method described above.

This PR optimizes this behavior in a weakly backwards-compatible fashion by ensuring global uniqueness of message uids on the database level (by using UNIQUE constraint), merging all the uids in the received messages and performing a single query on indexed columns agent_did and uid on the messages table.

Signed-off-by: Miroslav Kovar [email protected]

[Patrik-Stas]

Please add PR description of this, formally, breaking change.

[Patrik-Stas]

In test

agent-msgs.spec.js /  "should update statusCodes of messages"

Lets change

    const uidsByConn = [
      { pairwiseDID: aconn1UserPwDid, uids: [msg1Id, msg2Id] },
      { pairwiseDID: aconn2UserPwDid, uids: [msg6Id] }
    ]

to something like

    const uidsByConn = [
      { pairwiseDID: "not-taken-in-consideration", uids: [msg1Id, msg2Id] },
      { pairwiseDID: "not-taken-in-consideration", uids: [msg6Id] }
    ]

to signal that pairwiseDID makes not difference anymore.

• Note: Added issue to deprecate this message type itself eventually Add new status update message type #161

[Patrik-Stas]

left comments