feat: define missing types (in progress) #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kuamanet for this valuable PR. Comment here once it is ready from your side. |
|
@kuamanet very nice! 🚀 |
|
Hi @kuamanet and @Abhinandan-Kushwaha what is stopping this to be merged? :) I could help you if needed. |
@Vondry This PR contains a temporary workaround full of 'any' types and one ts-nocheck. I think this should be handled properly instead of using 'any' everywhere |
|
@christophby @christophby @kulak91 Sorry, I gave up after Abhinandan-Kushwaha/gifted-charts-core#6 (comment) :/ Feel free to jump-in if you want! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first the PR on gifted-charts-core
As the other PR, this is not a complete work, it just allows people using typescript in their react native projects to add your library.
Once merged the one on
gifted-charts-corewe can update thepackage.jsonto point to the correct repo (yours)-