Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Search Functionality #122

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

I have added the search functionality

closes : #118

I have added the search functionality in all pages where it is needed and for that i have to configure the whole code so please give level 2 or 3 if found it suitable .

bandicam.2024-06-11.22-21-04-686.mp4

Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
75per ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 6:38am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@AbhiDiva96
Copy link
Owner

AbhiDiva96 commented Jun 12, 2024

hey @Ayushmaanagarwal1211
greate job but make sure some padding and margin in the search bar so that it look user friendly

your design

Screenshot 2024-06-12 082953

expected design

Screenshot 2024-06-12 083024

@Ayushmaanagarwal1211
Copy link
Contributor Author

Sure Doing

@Ayushmaanagarwal1211
Copy link
Contributor Author

@AbhiDiva96 Can you please check updated

@AbhiDiva96
Copy link
Owner

Make it more attractive use good quality css for responsive.
I can see that in mobile view it is not responsible.

Use a search toggle(🔍) within the search bar
Screenshot_2024-06-12-09-26-11-57_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

Screenshot_2024-06-12-09-25-37-50_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ok doing

@Ayushmaanagarwal1211
Copy link
Contributor Author

bandicam.2024-06-12.12-06-45-973.mp4

@AbhiDiva96 please check

@Ayushmaanagarwal1211
Copy link
Contributor Author

And if you have any suggestion for attractiveness of search bar please let me know i will do like that

@AbhiDiva96
Copy link
Owner

Hey @Ayushmaanagarwal1211
I already gave you an image above check it out and design accordingly

@AbhiDiva96
Copy link
Owner

I am merging it but needs improvement

@AbhiDiva96 AbhiDiva96 merged commit 90109cb into AbhiDiva96:main Jun 14, 2024
2 checks passed
Ayushmaanagarwal1211 added a commit to Ayushmaanagarwal1211/75per that referenced this pull request Jun 15, 2024
Merge pull request AbhiDiva96#122 from Ayushmaanagarwal1211/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Search Funtionality
2 participants