Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] ComfyUI-Manager #712

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nehemiascr
Copy link

Closes issue #711
This PR aims to install the ComfyUI-Manager when building the Comfy docker image

Copy link

@Gran5583 Gran5583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

comfy-cpu-1  |   10.4 seconds: /stable-diffusion/custom_nodes/ComfyUI-Manager
comfy-cpu-1  |
comfy-cpu-1  | ****** User settings have been changed to be stored on the server instead of browser storage. ******
comfy-cpu-1  | ****** For multi-user setups add the --multi-user CLI argument to enable multiple user profiles. ******
comfy-cpu-1  | ### Loading: ComfyUI-Manager (V2.48.6)
comfy-cpu-1  | ### ComfyUI Revision: 2197 [276f8fce] | Released on '2024-05-20'
comfy-cpu-1  | [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
comfy-cpu-1  | [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
comfy-cpu-1  | [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
comfy-cpu-1  | [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
comfy-cpu-1  | [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
comfy-cpu-1  | FETCH DATA from: /stable-diffusion/custom_nodes/ComfyUI-Manager/extension-node-map.json [DONE]

@BaconIsAVeg
Copy link

BaconIsAVeg commented Aug 13, 2024

The only issue seems to be that ComfyUI manager ignores the custom_nodes path defined in the extra paths yaml, so nodes installed via the Manager aren't stored on the data mount.

Related: ltdrdata/ComfyUI-Manager/issues/420

@fahadshery
Copy link

The only issue seems to be that ComfyUI manager ignores the custom_nodes path defined in the extra paths yaml, so nodes installed via the Manager aren't stored on the data mount.

Related: ltdrdata/ComfyUI-Manager/issues/420

I just installed and it works but is there a workaround for this?

@fahadshery
Copy link

Hi,

I have been trying to install custom nodes via GitHub and getting the error: This action is not allowed with this security level configuration.

Here is the docker file:

FROM pytorch/pytorch:2.3.0-cuda12.1-cudnn8-runtime

ENV DEBIAN_FRONTEND=noninteractive PIP_PREFER_BINARY=1

RUN apt-get update && apt-get install -y git && apt-get clean

ENV ROOT=/stable-diffusion
RUN --mount=type=cache,target=/root/.cache/pip \
  git clone https://github.com/comfyanonymous/ComfyUI.git ${ROOT} && \
  cd ${ROOT} && \
  git checkout master && \
  #git reset --hard 276f8fce9f5a80b500947fb5745a4dde9e84622d && \
  pip install -r requirements.txt

RUN git clone https://github.com/ltdrdata/ComfyUI-Manager ${ROOT}/custom_nodes/ComfyUI-Manager && \
  pip install -r ${ROOT}/custom_nodes/ComfyUI-Manager/requirements.txt

WORKDIR ${ROOT}
COPY . /docker/
RUN chmod u+x /docker/entrypoint.sh && cp /docker/extra_model_paths.yaml ${ROOT}

ENV NVIDIA_VISIBLE_DEVICES=all PYTHONPATH="${PYTHONPATH}:${PWD}" CLI_ARGS=""
EXPOSE 7860
ENTRYPOINT ["/docker/entrypoint.sh"]
CMD python -u main.py --listen --port 7860 ${CLI_ARGS}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. This would be great to merge, but I also understand that this does have potential side effects with an additional repo in the mix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants