removed tiles background in starting #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anurag-Sarkar
changed the title
Aatmaj-Zephyr
requested changes
Feb 28, 2023
|
Sorry I am new to contribution and learning, I hope I did all the things you asked for. |
|
Sure no probs. Thanks for the efforts |
|
Thanks a lot this was my first contribution, I really appreciate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On the starting of the game the tiles have a box shadow which revealed the white background of the tiles.
Screenshots of changes made to the webapp.
I removed the box shadow and removed the add style line in the loop that added that box styling to all the other boxes.
I verified it by playing the game and it worked all okay as I just changed the styling not any actual logic.
Related PRs and Issues
It is related to the PR issue #92 which also was raised to remove the background of tiles. but removing the box shadow was alo important
Have you updated the README.md file?
Have you made any big breakthrough change?
Is the code beautified?
Is the code clear to understand woth proper variable naming and comments?