Move the "get MethodDefSig from a MethodRefSig" functionality into dnmd::interfaces #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… walking scenarios.
…re a field signature is sometimes passed to this method.
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Dec 5, 2023
Co-authored-by: Aaron Robinson <[email protected]>
Co-authored-by: Aaron Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move our signature parsing functionality into dnmd::interfaces and built it such that we can build TranslateSigWithScope on the same functionality.
Use the
span<T>type from the tools indnmd::interfacesto make it easier to traverse the buffer. Use the CoreCLR compressed integer APIs that are inlined intocor.hinstead of exposing the APIs from DNMD.Remove the signature APIs from DNMD as this was the only use for them.