Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Aaron Robinson <[email protected]>
  • Loading branch information
jkoritzinsky and AaronRobinsonMSFT authored Jan 18, 2024
1 parent c6d6069 commit b51945b
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/dnmd/entry.c
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,11 @@ static bool initialize_minimal_table_rows(mdcxt_t* cxt)
if (1 != set_column_value_as_heap_offset(module_cursor, mdtModule_Mvid, 1, &guid_heap_offset)
|| 1 != set_column_value_as_heap_offset(module_cursor, mdtModule_EncBaseId, 1, &guid_heap_offset)
|| 1 != set_column_value_as_heap_offset(module_cursor, mdtModule_EncId, 1, &guid_heap_offset))
{
return false;
}

const char* name = "";
char const* name = "";
if (1 != md_set_column_value_as_utf8(module_cursor, mdtModule_Name, 1, &name))
return false;

Expand All @@ -284,7 +286,7 @@ static bool initialize_minimal_table_rows(mdcxt_t* cxt)
if (1 != md_set_column_value_as_constant(global_type_cursor, mdtTypeDef_Flags, 1, &flags))
return false;

const char* global_type_name = "<Module>";
char const* global_type_name = "<Module>"; // Defined in ECMA-335 II.10.8
if (1 != md_set_column_value_as_utf8(global_type_cursor, mdtTypeDef_TypeName, 1, &global_type_name))
return false;

Expand Down Expand Up @@ -330,7 +332,6 @@ mdhandle_t md_create_new_handle()
return pcxt;
}


bool md_apply_delta(mdhandle_t handle, void const* data, size_t data_len)
{
mdcxt_t* base = extract_mdcxt(handle);
Expand Down

0 comments on commit b51945b

Please sign in to comment.