Skip to content

Commit

Permalink
Change the "data to write" parameters in md_set_column_value_as_* m…
Browse files Browse the repository at this point in the history 
…ethods to be const. (#43)
  • Loading branch information
@jkoritzinsky
jkoritzinsky authored Nov 29, 2023
1 parent e171c43 commit 0ad79bf
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
14 changes: 7 additions & 7 deletions src/dnmd/write.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static bool is_row_sorted_with_next_row(md_key_info_t const* keys, uint8_t count
return true;
}

static int32_t set_column_value_as_token_or_cursor(mdcursor_t c, uint32_t col_idx, mdToken* tk, mdcursor_t* cursor, uint32_t in_length)
static int32_t set_column_value_as_token_or_cursor(mdcursor_t c, uint32_t col_idx, mdToken const* tk, mdcursor_t const* cursor, uint32_t in_length)
{
assert(in_length != 0 && (tk != NULL || cursor != NULL));

Expand Down Expand Up @@ -170,21 +170,21 @@ static int32_t set_column_value_as_token_or_cursor(mdcursor_t c, uint32_t col_id
return written;
}

int32_t md_set_column_value_as_token(mdcursor_t c, col_index_t col, uint32_t in_length, mdToken* tk)
int32_t md_set_column_value_as_token(mdcursor_t c, col_index_t col, uint32_t in_length, mdToken const* tk)
{
if (tk == NULL || in_length == 0)
return -1;
return set_column_value_as_token_or_cursor(c, col_to_index(col, CursorTable(&c)), tk, NULL, in_length);
}

int32_t md_set_column_value_as_cursor(mdcursor_t c, col_index_t col, uint32_t in_length, mdcursor_t* cursor)
int32_t md_set_column_value_as_cursor(mdcursor_t c, col_index_t col, uint32_t in_length, mdcursor_t const* cursor)
{
if (cursor == NULL || in_length == 0)
return -1;
return set_column_value_as_token_or_cursor(c, col_to_index(col, CursorTable(&c)), NULL, cursor, in_length);
}

int32_t md_set_column_value_as_constant(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint32_t* constant)
int32_t md_set_column_value_as_constant(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint32_t const* constant)
{
if (in_length == 0)
return 0;
Expand Down Expand Up @@ -322,7 +322,7 @@ int32_t set_column_value_as_heap_offset(mdcursor_t c, col_index_t col_idx, uint3
return written;
}

int32_t md_set_column_value_as_utf8(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char const** str)
int32_t md_set_column_value_as_utf8(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char const* const* str)
{
if (in_length == 0)
return 0;
Expand Down Expand Up @@ -362,7 +362,7 @@ int32_t md_set_column_value_as_utf8(mdcursor_t c, col_index_t col_idx, uint32_t
return written;
}

int32_t md_set_column_value_as_blob(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint8_t const** blob, uint32_t* blob_len)
int32_t md_set_column_value_as_blob(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint8_t const* const* blob, uint32_t const* blob_len)
{
if (in_length == 0)
return 0;
Expand Down Expand Up @@ -428,7 +428,7 @@ int32_t md_set_column_value_as_guid(mdcursor_t c, col_index_t col_idx, uint32_t
return written;
}

int32_t md_set_column_value_as_userstring(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char16_t const** userstring)
int32_t md_set_column_value_as_userstring(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char16_t const* const* userstring)
{
if (in_length == 0)
return 0;
Expand Down
12 changes: 6 additions & 6 deletions src/inc/dnmd.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -489,13 +489,13 @@ bool md_resolve_indirect_cursor(mdcursor_t c, mdcursor_t* target);

// Set row's column values
// The returned number represents the number of rows updated.
int32_t md_set_column_value_as_token(mdcursor_t c, col_index_t col, uint32_t in_length, mdToken* tk);
int32_t md_set_column_value_as_cursor(mdcursor_t c, col_index_t col, uint32_t in_length, mdcursor_t* cursor);
int32_t md_set_column_value_as_constant(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint32_t* constant);
int32_t md_set_column_value_as_utf8(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char const** str);
int32_t md_set_column_value_as_blob(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint8_t const** blob, uint32_t* blob_len);
int32_t md_set_column_value_as_token(mdcursor_t c, col_index_t col, uint32_t in_length, mdToken const* tk);
int32_t md_set_column_value_as_cursor(mdcursor_t c, col_index_t col, uint32_t in_length, mdcursor_t const* cursor);
int32_t md_set_column_value_as_constant(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint32_t const* constant);
int32_t md_set_column_value_as_utf8(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char const* const* str);
int32_t md_set_column_value_as_blob(mdcursor_t c, col_index_t col_idx, uint32_t in_length, uint8_t const* const* blob, uint32_t const* blob_len);
int32_t md_set_column_value_as_guid(mdcursor_t c, col_index_t col_idx, uint32_t in_length, mdguid_t const* guid);
int32_t md_set_column_value_as_userstring(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char16_t const** userstring);
int32_t md_set_column_value_as_userstring(mdcursor_t c, col_index_t col_idx, uint32_t in_length, char16_t const* const* userstring);

// Create a new row logically before the row specified by the cursor.
// If the given row is in a table that is a target of a list column, this function will return false.
Expand Down

0 comments on commit 0ad79bf

Please sign in to comment.