[HAR-147] Search input control #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengunneweg
requested review from
edgargressie,
michaelmaat,
bartvandebiezen and
romypetitjean
|
TODO:
|
…rch-input-control * origin/master: Up version number and update changelog [HAR-48] fixed typo in changelog [HAR-48] Added line to changelog [HAR-48] Added docs for text-input [HAR-48] Added text input control Add travis build status badge to readme # Conflicts: # CHANGELOG.md # docs/README.md
|
Changed base branch to develop for now. When the WIP label is removed we can change the base branch to the release which is active at that time. GitHub closed this PR every week when we release a new version... |
…arch-input-control * origin/develop: (91 commits) Up version and add changelog Pin ajv dependency because of error in the 'equal' module Update version and add changelog Fix relative url to contributing section Add 1.18.0 changes to changelog Add Gemfile.lock to gitignore Update version in packages json [HAR-166] Remove outdated reset import comment [HAR-165] Combine sentences in documentation [HAR-166] Update stylint-order to 2.0.0 [HAR-166] Update Gemfile.lock [HAR-166] Update (S)CSS dependencies [HAR-170] Add layout section left aligning modifier [HAR-165] Add more detailed explanation about running Harbour locally: installing rbenv, ruby, jekyll. [HAR-166] Update packages and remove unused ones [HAR-166] Replace deprecated gup-util logging with fancy log [HAR-118] Update layout documentation. Combine city block modifiers. Add changelog and update version in package json Add documentation for Github pages deployments Add package version and creation time to footer ... # Conflicts: # CHANGELOG.md # docs/README.md
…arch-input-control * origin/develop: (57 commits) Up version Add changelog Add missing commas to srcset Up version Add changelog Add relative url pipe to placeholder images to fix images on GitHub pages Up version to 1.20.0 Add changelog [HAR-163] Keep using cursor pointer for now. Cursor use wil be fixed in HAR-195. [HAR-163] Add newline at end of file [HAR-163] Expand tag comments [HAR-163] Adds newline at end of file [HAR-163] Add tag documentation [HAR-163] Rename sixteen-nine to wide and widescreen to ultra-wide [HAR-163] Remove Gemfile.lock from project [HAR-163] Match title capitalization with other docs [HAR-163] Remove transparant background color for flat card [HAR-163] Remove color-background for now [HAR-163] Clarify styling modifiers for card [HAR-163] Rename aspect ratios ... # Conflicts: # CHANGELOG.md # scss/controls/index.scss # scss/icons/harbour-icons.scss
edgargressie
changed the title
…arch-input-control * origin/develop: (40 commits) Add changelog and up version Fix link to contributing guidelines Fix stylelint error Add changelog Fix border radius for when focus state is collapsed Undo last commit Remove border-radius from :focus Fix card border-radius Update package.json and changelog to 1.21.5 Add drop down menu icon local variable Add drop-down menu to control import index file and reorder imports Replace spaces by tabs in drop-down menu Remove padding top and bottom from drop-down menu Add right icon variable to drop-down menu Up version in package json Update changelog for 1.21.4 Revert change in button cursor reset Remove card-border comment from changelog Remove border-variable as can be fixed with box-shadow Update changelog ... # Conflicts: # CHANGELOG.md # scss/controls/index.scss # site/docs/index.md
…arch-input-control # Conflicts: # CHANGELOG.md # site/index.md
|
Visual example: https://harbour.aanzee.cc/feature/HAR-147-search-input-control/controls/search-input.html Looks good, maybe clean up the variations overview with the preferred examples only. |
edgargressie
suggested changes
Jan 9, 2019
| width: 100%; | ||
| height: $control-size-100; | ||
| border: $search-input-border; | ||
| border-top-left-radius: $search-input-border-radius; |
There was a problem hiding this comment.
I think we need to use the $input-border-radius since we don't want to provide to many different input variations.
…arch-input-control
michaelmaat
approved these changes
Feb 28, 2019
…arch-input-control * origin/develop: (57 commits) [1.24.0] Update package version and added changelog [HAR-104] Add right default values to top-aligned-labels form elements [HAR-104] Add top-aligned reset styling for form__actions [HAR-104] Add helper and feedback text example to form examples [HAR-104] Add paragraph to form section content example [HAR-104] Fix reload on files in nested folders [HAR-104] Reorder form examples [HAR-104] Add address-level2 as autocomplete attribute for city [HAR-104] Add autocomplete username [HAR-104] Fix discrepancies between form modifiers [HAR-104] Fix attributes for city field [HAR-104] Hide password by default [HAR-104] Fix stylelint error [HAR-104] Remove commented feedback text labels [HAR-104] Rename sections form to advanced form, add content to form section and show link instead of secondary button [HAR-104] Remove top spacing and indent content [HAR-104] Clean up code example markdown [HAR-104] Add control example to form dom structure [HAR-104] Remove no-border modifier, as this is not an issue at the moment in projects [HAR-104] Move input-feedback-text inside field-section ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.