Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaces phone validation #44

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Add spaces phone validation #44

merged 3 commits into from
Oct 10, 2024

Conversation

aditig0305
Copy link
Collaborator

No description provided.

@aditig0305 aditig0305 added this to the v1.2 milestone Oct 10, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...rc/main/java/seedu/address/model/person/Phone.java 93.33% <100.00%> (+0.47%) 6.00 <0.00> (ø)

@aditig0305
Copy link
Collaborator Author

closes #45

Sornsornah
Sornsornah approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Sornsornah Sornsornah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sornsornah Sornsornah merged commit 9dfb47f into AY2425S1-CS2103T-T11-4:master Oct 10, 2024
4 checks passed
@aditig0305 aditig0305 linked an issue Oct 10, 2024 that may be closed by this pull request
Begin editing validation for phone number #45
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sornsornah Sornsornah Sornsornah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Begin editing validation for phone number
2 participants
@aditig0305 @Sornsornah