Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate inputs for add feature #43

Closed
wants to merge 14 commits into from
Closed

Validate inputs for add feature #43

wants to merge 14 commits into from

Conversation

nayanaamahesh
Copy link

Closes #40

@nayanaamahesh
Update Tag to only allow one tag
29daf55 
Each patient in the address book only has one tag.
This tag can only be one of the following:
1. Low Risk
2. Medium Risk
3. High Risk
@nayanaamahesh
Update tests for new tag requirements.
4ce1ff1
@nayanaamahesh
Update Checkstyle configuration.
4e3f17b
@nayanaamahesh
Update user guide to reflect changes to tag requirements
bb05066
@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/seedu/address/storage/JsonAdaptedPerson.java 87.50% 0 Missing and 1 partial ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
src/main/java/seedu/address/logic/Messages.java 87.50% <100.00%> (ø) 3.00 <0.00> (ø)
.../java/seedu/address/logic/commands/AddCommand.java 100.00% <ø> (ø) 8.00 <0.00> (ø)
...java/seedu/address/logic/commands/EditCommand.java 97.43% <100.00%> (ø) 13.00 <0.00> (ø)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 100.00% <100.00%> (+7.40%) 8.00 <0.00> (-3.00) ⬆️
...in/java/seedu/address/logic/parser/ParserUtil.java 96.66% <ø> (-0.56%) 12.00 <0.00> (-2.00)
...c/main/java/seedu/address/model/person/Person.java 100.00% <100.00%> (+2.77%) 20.00 <3.00> (+1.00)
src/main/java/seedu/address/model/tag/Tag.java 100.00% <100.00%> (+28.57%) 7.00 <1.00> (+2.00)
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% <ø> (-20.00%) 0.00 <0.00> (-1.00)
.../java/seedu/address/storage/JsonAdaptedPerson.java 97.43% <87.50%> (-2.57%) 11.00 <10.00> (ø)
... and 1 more

... and 4 files with indirect coverage changes

@nayanaamahesh nayanaamahesh added this to the v1.3 milestone Oct 10, 2024
@nayanaamahesh nayanaamahesh self-assigned this Oct 10, 2024
@nayanaamahesh
Copy link
Author

Please dont PR this yet the codeCov is not 100%

nayanaamahesh and others added 3 commits October 11, 2024 18:29
@nayanaamahesh
Merge pull request #5 from AY2425S1-CS2103T-T11-4/master
87d5961 
Pull Request Week 8
@nayanaamahesh
Merge branch 'master' into validate-inputs-for-add-feature
ddbc846 
* master:
  Change input message
  Add delete string
  Refactor list command to view command
  Edit constructor name
  Add phone test cases
  Add spaces phone validation
  Update DeveloperGuide with user stories, NFRs and glossary
  Update DeveloperGuide with user stories, NFRs and glossary
  Update GitHub Actions build status badge to reflect team repo
  Update README.md
  Update site-wide settings
  Add use cases
  Update developer guide
@nayanaamahesh
Improve code coverage
0b79b9f
@nayanaamahesh nayanaamahesh reopened this Oct 14, 2024
@nayanaamahesh
Copy link
Author

nayanaamahesh commented Oct 14, 2024 •
edited
Loading

Minor changes required dont merge yet

@nayanaamahesh
Copy link
Author

Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nayanaamahesh nayanaamahesh

Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

validate the inputs for add feature
2 participants
@nayanaamahesh @Sornsornah