Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter articles by tag #85

Merged
merged 14 commits into from
Mar 30, 2024
Merged

Filter articles by tag #85

merged 14 commits into from
Mar 30, 2024

Conversation

Ko-Khan
Copy link
Collaborator

@Ko-Khan Ko-Khan commented Mar 30, 2024

No description provided.

@Ko-Khan Ko-Khan added enhancement New feature or request priority.High Must do labels Mar 30, 2024
@Ko-Khan Ko-Khan added this to the v1.3b milestone Mar 30, 2024
@Ko-Khan Ko-Khan self-assigned this Mar 30, 2024
@Ko-Khan Ko-Khan linked an issue Mar 30, 2024 that may be closed by this pull request
As an experienced user, I can filter articles by tags #84
Closed
@Ko-Khan Ko-Khan changed the title filter articles by tag Filter articles by tag Mar 30, 2024
@Ko-Khan
Remove redundant import
1c194fa 
Add whitespace behind comma
@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 49.25%. Comparing base (c3e43e2) to head (f434f93).

Files Patch % Lines
...ress/model/article/ArticleMatchesTagPredicate.java 0.00% 13 Missing ⚠️
...commands/articlecommands/FilterArticleCommand.java 0.00% 8 Missing ⚠️
...dress/logic/parser/FilterArticleCommandParser.java 0.00% 6 Missing ⚠️
.../seedu/address/logic/parser/ArticleBookParser.java 0.00% 1 Missing ⚠️
...s/model/article/ArticleMatchesStatusPredicate.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #85      +/-   ##
============================================
- Coverage     49.72%   49.25%   -0.48%     
  Complexity      452      452              
============================================
  Files           111      112       +1     
  Lines          2196     2217      +21     
  Branches        232      236       +4     
============================================
  Hits           1092     1092              
- Misses         1065     1086      +21     
  Partials         39       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Murugan-Maniish
Murugan-Maniish approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@Murugan-Maniish Murugan-Maniish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't need to change the name to filter but it does make it much more easier to understand what is happening.

src/main/java/seedu/address/model/article/ArticleMatchesTagPredicate.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ko-Khan Ko-Khan merged commit ee34dd3 into AY2324S2-CS2103T-F12-2:master Mar 30, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murugan-Maniish Murugan-Maniish Murugan-Maniish approved these changes

Assignees

@Ko-Khan Ko-Khan

Labels
enhancement New feature or request priority.High Must do
Projects
None yet
Milestone
v1.3b
Development

Successfully merging this pull request may close these issues.

As an experienced user, I can filter articles by tags
2 participants
@Ko-Khan @Murugan-Maniish