Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Authors, Sources and Tags classes #60

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

H4mes
Copy link
Collaborator

@H4mes H4mes commented Mar 27, 2024

Added classes for author, source and tag.

Added tag pill UI elements for authors, sources and tags.

Added classes for author, source and tag.

Added tag pill UI elements for authors, sources and tags.
@H4mes H4mes requested a review from Howlong11 March 27, 2024 01:11
@H4mes H4mes linked an issue Mar 27, 2024 that may be closed by this pull request
@H4mes H4mes added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0.53191% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 52.64%. Comparing base (585ed77) to head (8246758).
Report is 2 commits behind head on master.

Files Patch % Lines
...java/seedu/address/storage/JsonAdaptedArticle.java 0.00% 34 Missing ⚠️
...main/java/seedu/address/model/article/Article.java 0.00% 32 Missing ⚠️
...c/commands/articlecommands/EditArticleCommand.java 0.00% 15 Missing ⚠️
...address/logic/parser/EditArticleCommandParser.java 0.00% 14 Missing ⚠️
.../main/java/seedu/address/model/article/Author.java 0.00% 14 Missing ⚠️
.../main/java/seedu/address/model/article/Source.java 0.00% 14 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 12 Missing ⚠️
...eedu/address/model/util/SampleArticleDataUtil.java 0.00% 11 Missing ⚠️
.../java/seedu/address/storage/JsonAdaptedAuthor.java 0.00% 10 Missing ⚠️
.../java/seedu/address/storage/JsonAdaptedSource.java 0.00% 10 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     55.38%   52.64%   -2.75%     
  Complexity      451      451              
============================================
  Files            97      101       +4     
  Lines          1959     2061     +102     
  Branches        200      216      +16     
============================================
  Hits           1085     1085              
- Misses          835      937     +102     
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H4mes H4mes self-assigned this Mar 27, 2024
Copy link
Collaborator

@Ko-Khan Ko-Khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe check the tests to ensure they are still working, as you changed a lot of old code

Copy link
Collaborator

@bennyLCK bennyLCK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some possible flaws to rectify are present.

Copy link
Collaborator

@bennyLCK bennyLCK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bennyLCK bennyLCK merged commit fdaebf1 into AY2324S2-CS2103T-F12-2:master Mar 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor article tags, authors and sources as classes
3 participants