Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link not reflected in add and edit commands #119

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

H4mes
Copy link
Collaborator

@H4mes H4mes commented Apr 4, 2024

Fixes #118
Additionally made empty links not take up UI space.

@H4mes H4mes requested a review from Howlong11 April 4, 2024 17:16
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.11%. Comparing base (f740fa3) to head (cae96a6).
Report is 2 commits behind head on master.

Files Patch % Lines
...address/logic/parser/EditArticleCommandParser.java 0.00% 2 Missing ⚠️
src/main/java/seedu/address/ui/ArticleCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
- Coverage     45.20%   45.11%   -0.10%     
- Complexity      465      466       +1     
============================================
  Files           121      121              
  Lines          2484     2487       +3     
  Branches        260      261       +1     
============================================
- Hits           1123     1122       -1     
- Misses         1318     1321       +3     
- Partials         43       44       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Howlong11 Howlong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@H4mes H4mes merged commit f445560 into AY2324S2-CS2103T-F12-2:master Apr 4, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix commands not reflecting new Link features
2 participants