Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appointment parser tests #241

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

licongshen12
Copy link

@licongshen12 licongshen12 commented Nov 9, 2023

Fixes #176

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #241 (1c8e4ff) into master (b84dad3) will increase coverage by 1.21%.
The diff coverage is 56.52%.

@@             Coverage Diff              @@
##             master     #241      +/-   ##
============================================
+ Coverage     73.63%   74.84%   +1.21%     
- Complexity      750      767      +17     
============================================
  Files           125      125              
  Lines          2446     2461      +15     
  Branches        239      240       +1     
============================================
+ Hits           1801     1842      +41     
+ Misses          537      511      -26     
  Partials        108      108              
Files Coverage Δ
...seedu/address/logic/parser/ClearCommandParser.java 40.00% <100.00%> (ø)
.../seedu/address/logic/parser/ExitCommandParser.java 40.00% <100.00%> (ø)
.../seedu/address/logic/parser/HelpCommandParser.java 40.00% <100.00%> (ø)
.../seedu/address/logic/parser/ListCommandParser.java 40.00% <100.00%> (ø)
.../seedu/address/logic/parser/ModeCommandParser.java 40.00% <100.00%> (ø)
...r/appointmentparser/AppointmentsCommandParser.java 100.00% <100.00%> (+60.00%) ⬆️
...c/parser/appointmentparser/TodayCommandParser.java 100.00% <100.00%> (+60.00%) ⬆️
...arser/appointmentparser/UpcomingCommandParser.java 100.00% <100.00%> (+100.00%) ⬆️
...mands/appointmentcommands/AppointmentsCommand.java 71.42% <33.33%> (-28.58%) ⬇️
...gic/commands/appointmentcommands/TodayCommand.java 75.00% <33.33%> (-25.00%) ⬇️
... and 2 more

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@trgao trgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trgao trgao merged commit 9b9d947 into AY2324S1-CS2103T-T08-4:master Nov 9, 2023
@licongshen12 licongshen12 added this to the v1.4 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add appointment command parser tests
2 participants