Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples update #9

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Samples update #9

merged 5 commits into from
Sep 8, 2023

Conversation

avv-nkrisa
Copy link
Collaborator

Updates made to sample after comments from Collin Bardini

Copy link
Contributor

@cbardini cbardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good for the most part! As we discussed before, the sleeps are fine for the time being given the limitations of the service. My team will revisit this in the future to assess if we can change out the sleeps for polling loops with timeouts.

StreamingUpdatesRestApi/PressureTemperatureData.cs Outdated Show resolved Hide resolved
StreamingUpdatesRestApi/Program.cs Show resolved Hide resolved
StreamingUpdatesRestApi/Program.cs Outdated Show resolved Hide resolved
StreamingUpdatesRestApi/Signup.cs Show resolved Hide resolved
@avv-nkrisa avv-nkrisa merged commit c78e4bf into main Sep 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants