Feat AboutAusgCon page to activities tab #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geun-Oh
approved these changes
Jun 15, 2024
|
|
||
| const Activities = () => { | ||
| const [currentTab, setCurrentTab] = useState<'bigchat' | 'study'>('bigchat'); | ||
| const [currentTab, setCurrentTab] = useState<'bigchat' | 'ausgcon'>( |
There was a problem hiding this comment.
요기는 나중에 활동들 더 추가되면 따로 유니온 타입으로 빼버려도 될 듯 (리뉴얼에서)
Comment on lines
+65
to
+70
| <svg width={32} height={32} viewBox="0 0 532 532"> | ||
| <path | ||
| fill="currentColor" | ||
| d="M355.66 11.354c13.793-13.805 36.208-13.805 50.001 0 13.785 13.804 13.785 36.238 0 50.034L201.22 266l204.442 204.61c13.785 13.805 13.785 36.239 0 50.044-13.793 13.796-36.208 13.796-50.002 0a5994246.277 5994246.277 0 0 0-229.332-229.454 35.065 35.065 0 0 1-10.326-25.126c0-9.2 3.393-18.26 10.326-25.2C172.192 194.973 332.731 34.31 355.66 11.354Z" | ||
| /> | ||
| </svg> |
There was a problem hiding this comment.
나중에는 svg도 싹 빼버리는 것도 갠춘할지도..? 굳이인가 (의견만 메모)
There was a problem hiding this comment.
원래는 뺐었는데,, 일단 아이콘이 라이브러리로 관리되고 있지 않아서 추후 리뉴얼에서는 아이콘은 라이브러리로 관리할 듯!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. . 이 PR을 마무리로 2024 홈페이지 리뉴얼로 넘어가야할 것 같습니다,,! (clear legacy)